This repository was archived by the owner on Feb 4, 2023. It is now read-only.
Fix typo in JVMOptions expansion on java call #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
version 2.1.0
Merge pull request #60 from tofi86/develop
A curly brace is missing from the JVMOptions array expansion causing errors such as the following when JVMOptions are in use: Invalid maximum heap size: -Xmx1G[@]} Error: Could not create the Java Virtual Machine. Error: A fatal exception has occurred. Program will exit.
|
Thanks for providing this fix! Good catch! 👏 I cherry-picked your commit into the current This patch fixes shellcheck error |
Merged
|
released as version 3.0.2. Thanks for your contribution! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A curly brace is missing from the JVMOptions array expansion causing
errors such as the following when JVMOptions are in use:
Invalid maximum heap size: -Xmx1G[@]}
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.