Doc tweaks #313
Merged
Doc tweaks #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I used https://github.com/kristoff-it/superhtml to find the fixes and would recommend using its |
Found using superhtml: ``` $ superhtml check doc/_templates/index.html doc/_templates/index.html:5:3: html_elements_cant_self_close doc/_templates/index.html:37:72: erroneous_end_tag doc/_templates/index.html:38:76: missing_end_tag doc/_templates/index.html:38:30: missing_end_tag ``` Signed-off-by: Manuel Mendez <[email protected]>
Other sub-sections have Sentence case, this was the only one with initial caps. Signed-off-by: Manuel Mendez <[email protected]>
README was missing Gentoo. Moved Arch linux up so the almost alphabetically sorted linux distros would in fact be sorted. I split OSX from "Other Linux" in index.html to match the other files. I changed the content to point to intro.html#installing-flent as it wasn't a one/two liner like the others so seemed to be better off as a link. Signed-off-by: Manuel Mendez <[email protected]>
Signed-off-by: Manuel Mendez <[email protected]>
Owner
|
No objection to any of these, thanks for the fixes! And sure, feel free to add a reformat commit as well, and I'll take a look... |
Originally tried with prettier but I think superhtml's output is nicer. Signed-off-by: Manuel Mendez <[email protected]>
Contributor
Author
|
I've added the re-format commit. |
tohojo
approved these changes
Dec 6, 2024
Owner
tohojo
left a comment
There was a problem hiding this comment.
Looks good - thank you for the fixes! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bunch of minor fixes and then adding nix to the list of oses that packages flent.
The fixes are mostly cosmetic tweaks, more info in the commit messages.