Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ci(tests) Verify runtime deps #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ci(tests) Verify runtime deps #441

wants to merge 1 commit into from

Conversation

tony
Copy link
Owner

@tony tony commented Feb 20, 2025 •
edited by sourcery-ai bot
Loading

Changes

  • Add runtime dependency check in CI using uv run --no-dev
  • Run check before installing dev dependencies
  • Print package version and basic functionality test results
  • Document improvement in CHANGES

Summary by Sourcery

Adds a CI check to verify runtime dependencies are correctly installed and functional before installing development dependencies.

CI:

  • Adds a CI check to verify runtime dependencies using uv run --no-dev before installing dev dependencies.
  • The check prints the package version and runs basic functionality tests.

@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented Feb 20, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request introduces a new CI check to verify runtime dependencies using uv run --no-dev. This check is executed before installing dev dependencies to ensure that the project can run with only its runtime dependencies. The pull request also includes documentation of this improvement in CHANGES.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a CI check to verify runtime dependencies using uv run --no-dev.
  • Added a new job to the CI workflow to test runtime dependencies.
  • The job uses uv run --no-dev to execute a Python script that imports and tests basic functionality.
  • The check is run before installing dev dependencies.
 .github/workflows/tests.yml
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Feb 20, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tony - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using sys.version_info instead of string formatting to specify the Python version.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tony