Conversation
kkartunov
approved these changes
Jan 9, 2025
Collaborator
kkartunov
left a comment
There was a problem hiding this comment.
That is great elevation of the stack. Thanks you!
Let's put it to sanity test to ensure all works as before...
jmgasper
reviewed
Jan 9, 2025
Collaborator
jmgasper
left a comment
There was a problem hiding this comment.
@vas3a - It doesn't seem like this is building properly? From CircleCI:
error [email protected]: The engine "node" is incompatible with this module. Expected version ">=18". Got "16.14.2"
error Found incompatible module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-459
What's in this PR?
migrated dependencies to mitigate security issues.
also updated node version to latest LTS (22.13) since it is working as expected after some basic testing
NOTE: I did not upgrade the dependecies for earn as they were causing too much issues and will remove the app in a new PR