Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

ippotim
Copy link

@ippotim ippotim commented Nov 3, 2016

Hello,world!

@ippotim ippotim closed this Nov 3, 2016
krzk pushed a commit to krzk/linux that referenced this pull request May 15, 2017
…eckpatch-fixes

ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
torvalds#14:
(lkml.kernel.org/g/<20160119112812.GA10818@mwanda>)

ERROR: code indent should use tabs where possible
torvalds#251: FILE: mm/page_poison.c:15:
+        if (!buf)$

WARNING: please, no spaces at the start of a line
torvalds#251: FILE: mm/page_poison.c:15:
+        if (!buf)$

ERROR: code indent should use tabs where possible
torvalds#252: FILE: mm/page_poison.c:16:
+                return -EINVAL;$

WARNING: please, no spaces at the start of a line
torvalds#252: FILE: mm/page_poison.c:16:
+                return -EINVAL;$

ERROR: code indent should use tabs where possible
torvalds#254: FILE: mm/page_poison.c:18:
+        if (strcmp(buf, "on") == 0)$

WARNING: please, no spaces at the start of a line
torvalds#254: FILE: mm/page_poison.c:18:
+        if (strcmp(buf, "on") == 0)$

ERROR: code indent should use tabs where possible
torvalds#255: FILE: mm/page_poison.c:19:
+                want_page_poisoning = true;$

WARNING: please, no spaces at the start of a line
torvalds#255: FILE: mm/page_poison.c:19:
+                want_page_poisoning = true;$

ERROR: code indent should use tabs where possible
torvalds#259: FILE: mm/page_poison.c:23:
+        return 0;$

WARNING: please, no spaces at the start of a line
torvalds#259: FILE: mm/page_poison.c:23:
+        return 0;$

WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...
torvalds#352: FILE: mm/page_poison.c:116:
+		printk(KERN_ERR "pagealloc: single bit error\n");

WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...
torvalds#354: FILE: mm/page_poison.c:118:
+		printk(KERN_ERR "pagealloc: memory corruption\n");

total: 6 errors, 7 warnings, 311 lines checked

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

./patches/mm-debug-pageallocc-split-out-page-poisoning-from-debug-page_alloc.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Laura Abbott <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
foxconn-bmc-ks pushed a commit to foxconn-bmc-ks/linux that referenced this pull request Oct 27, 2017
ftgmac100: Cleanup rx checksum handling

Read the descriptor field only once and check for IP header
checksum errors as well

Change-Id: I93c0b30101b5394672e06746d91eb43d150c1842
Signed-off-by: Benjamin Herrenschmidt <[email protected]>
Signed-off-by: Wei-Chung Wen <[email protected]>

Related work items: torvalds#354
foxconn-bmc-ks pushed a commit to foxconn-bmc-ks/linux that referenced this pull request Oct 27, 2017
ftgmac100: re-calculate checksum in case of RX CRC error

According to experiment, Aspeed 2400 sometimes reports RX CRC Error when
in fact there is none.

To prevent such false positives, this commit asks kernel to re-calculate
checksum in case of RX CRC error.

Change-Id: Icd2ff81ab433c20dd3298b4d6b39e6c16495536b
Signed-off-by: Wei-Chung Wen <[email protected]>

Related work items: torvalds#354
Mic92 pushed a commit to Mic92/linux that referenced this pull request Feb 4, 2019
akiernan pushed a commit to zuma-array/linux that referenced this pull request Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant