Code review #1
Code review #1
Conversation
|
|
||
| export class RangeDatePipe implements PipeTransform { | ||
| transform(rangeDates: any, args?: any): any { | ||
| if (rangeDates) { |
There was a problem hiding this comment.
This can be part of shared.module.ts
We can reuse this pipe somewhere else
src/app/angularMaterial.module.ts
Outdated
| MatSelectModule, | ||
| MatToolbarModule | ||
| MatRippleModule, | ||
| MatSnackBarModule |
There was a problem hiding this comment.
file name should be kebab-case
|
|
||
| export class ApiService { | ||
|
|
||
| FB_APP_ID = '303059286557418'; |
There was a problem hiding this comment.
We don't need this file to handle constants.
Instead, we should use environment files.
| let user = this.cookieService.getCookie("townscript-user"); | ||
| console.log("got user from cookie" + user); | ||
| if (user != null && user.length > 0) { | ||
| this.updateUser(JSON.parse(user)); |
| } | ||
| return null; | ||
| } | ||
|
|
There was a problem hiding this comment.
It can be part of shared module
| </div> | ||
| <div class="flex items-center cursor-pointer" (click)="userMenu=!userMenu" *ngIf="user" matRipple> | ||
| <img class="rounded-full mr-2" width="36" | ||
| [src]="'https://s3.ap-south-1.amazonaws.com/townscript-testing/images/'+user?.s3imagename" /> |
There was a problem hiding this comment.
Remove hardcoding of baseUrl
| <div class="flex items-center border-b py-2 border-gray-300"> | ||
| <div class="mr-1 leading-none"> | ||
| <img class="rounded-full mr-2" width="45" | ||
| [src]="'https://s3.ap-south-1.amazonaws.com/townscript-testing/images/'+user?.s3imagename" /> |
There was a problem hiding this comment.
Remove hardcoding of baseUrl
| <img | ||
| src="https://s3.ap-southeast-1.amazonaws.com/common-resources/assets/facebook-min-new.png" /> | ||
| </div> | ||
| <div class="text-sm"> |
There was a problem hiding this comment.
Remove hardcoding of baseUrl
| export class UserMenuComponent implements OnInit { | ||
|
|
||
| @Input("panelOpen1") panelOpen1: boolean = false; | ||
| @Input("panelOpen2") panelOpen2: boolean = false; |
There was a problem hiding this comment.
wrong naming convention
| } | ||
| logout() { | ||
| this.close.emit(); | ||
| this.cookieService.deleteCookie("townscript-user"); |
There was a problem hiding this comment.
We can have one method like - deleteUserCookie to avoid passing the name of cookie
Set physical href in header logo
privacy logos update
logos update
No description provided.