Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix ndarray remainder broadcasting #5002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laggui merged 1 commit into from
May 25, 2026
+33 −20
Merged

Fix ndarray remainder broadcasting #5002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions crates/burn-backend-tests/tests/tensor/int/ops/remainder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,18 @@ fn should_support_int_remainder_basic() {
output.into_data().assert_eq(&expected, false);
}

#[test]
fn should_support_int_remainder_broadcast() {
let device = Default::default();
let lhs = TestTensorInt::<2>::from_data(TensorData::from([[10, 20, 30]]), &device);
let rhs = TestTensorInt::<2>::from_data(TensorData::from([[7]]), &device);

let output = lhs.remainder(rhs);
let expected = TensorData::from([[3, 6, 2]]);

output.into_data().assert_eq(&expected, false);
}

#[test]
fn should_support_int_remainder_basic_scalar() {
let data = TensorData::from([-3, -2, -1, 1, 2, 3]);
Expand Down
41 changes: 21 additions & 20 deletions crates/burn-ndarray/src/ops/base.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,9 +673,9 @@ macro_rules! dispatch_unary_simd {
($elem: ty, $op: ty, $lhs: expr, $($ty: ty),*) => {{ $lhs }};
}

// Helper function to broadcast two tensors to a common shape for comparison operations
// Helper function to broadcast two tensors to a common shape for binary operations
// Returns broadcasted views that can be safely zipped
fn broadcast_for_comparison<'a, E: Copy, S1, S2>(
fn broadcast_for_binary_ops<'a, E: Copy, S1, S2>(
lhs: &'a ndarray::ArrayBase<S1, ndarray::IxDyn>,
rhs: &'a ndarray::ArrayBase<S2, ndarray::IxDyn>,
) -> (
Expand Down Expand Up @@ -842,16 +842,17 @@ where
}

pub fn remainder(lhs: SharedArray<E>, rhs: SharedArray<E>) -> SharedArray<E> {
// Use into_owned() instead of clone() - only copies if shared, avoids copy if unique
let mut out = lhs.into_owned();
Zip::from(&mut out).and(&rhs).for_each(|out_elem, &b| {
// out_elem holds lhs value; read it before overwriting with remainder
let a_f = (*out_elem).to_f64();
let b_f = b.to_f64();
let r = a_f - b_f * (a_f / b_f).floor();
*out_elem = r.elem();
});
out.into_shared()
let (lhs, rhs) = broadcast_for_binary_ops(&lhs, &rhs);

Zip::from(&lhs)
.and(&rhs)
.map_collect(|&a, &b| {
let a_f = a.to_f64();
let b_f = b.to_f64();
let r = a_f - b_f * (a_f / b_f).floor();
r.elem()
})
.into_shared()
}

pub fn remainder_scalar(lhs: SharedArray<E>, rhs: E) -> SharedArray<E>
Expand Down Expand Up @@ -983,7 +984,7 @@ where
);

// Use the helper to broadcast both arrays to a common shape
let (lhs_broadcast, rhs_broadcast) = broadcast_for_comparison(&lhs, &rhs);
let (lhs_broadcast, rhs_broadcast) = broadcast_for_binary_ops(&lhs, &rhs);
// Now we can safely zip and compare
Zip::from(&lhs_broadcast)
.and(&rhs_broadcast)
Expand Down Expand Up @@ -1183,7 +1184,7 @@ where
);

// Use the helper to broadcast both arrays to a common shape
let (lhs_broadcast, rhs_broadcast) = broadcast_for_comparison(&lhs, &rhs);
let (lhs_broadcast, rhs_broadcast) = broadcast_for_binary_ops(&lhs, &rhs);
// Now we can safely zip and compare
Zip::from(&lhs_broadcast)
.and(&rhs_broadcast)
Expand Down Expand Up @@ -1231,7 +1232,7 @@ where
);

// Use the helper to broadcast both arrays to a common shape
let (lhs_broadcast, rhs_broadcast) = broadcast_for_comparison(&lhs, &rhs);
let (lhs_broadcast, rhs_broadcast) = broadcast_for_binary_ops(&lhs, &rhs);
// Now we can safely zip and compare
Zip::from(&lhs_broadcast)
.and(&rhs_broadcast)
Expand Down Expand Up @@ -1266,7 +1267,7 @@ where
);

// Use the helper to broadcast both arrays to a common shape
let (lhs_broadcast, rhs_broadcast) = broadcast_for_comparison(&lhs, &rhs);
let (lhs_broadcast, rhs_broadcast) = broadcast_for_binary_ops(&lhs, &rhs);
// Now we can safely zip and compare
Zip::from(&lhs_broadcast)
.and(&rhs_broadcast)
Expand Down Expand Up @@ -1301,7 +1302,7 @@ where
);

// Use the helper to broadcast both arrays to a common shape
let (lhs_broadcast, rhs_broadcast) = broadcast_for_comparison(&lhs, &rhs);
let (lhs_broadcast, rhs_broadcast) = broadcast_for_binary_ops(&lhs, &rhs);

// Now we can safely zip and compare
Zip::from(&lhs_broadcast)
Expand Down Expand Up @@ -1446,7 +1447,7 @@ impl NdArrayBoolOps {
};

// Use the helper to broadcast both arrays to a common shape
let (lhs_broadcast, rhs_broadcast) = broadcast_for_comparison(&lhs, &rhs);
let (lhs_broadcast, rhs_broadcast) = broadcast_for_binary_ops(&lhs, &rhs);
// Now we can safely zip and compare
Zip::from(&lhs_broadcast)
.and(&rhs_broadcast)
Expand All @@ -1472,7 +1473,7 @@ impl NdArrayBoolOps {
};

// Use the helper to broadcast both arrays to a common shape
let (lhs_broadcast, rhs_broadcast) = broadcast_for_comparison(&lhs, &rhs);
let (lhs_broadcast, rhs_broadcast) = broadcast_for_binary_ops(&lhs, &rhs);
// Now we can safely zip and compare
Zip::from(&lhs_broadcast)
.and(&rhs_broadcast)
Expand All @@ -1488,7 +1489,7 @@ impl NdArrayBoolOps {
};

// Use the helper to broadcast both arrays to a common shape
let (lhs_broadcast, rhs_broadcast) = broadcast_for_comparison(&lhs, &rhs);
let (lhs_broadcast, rhs_broadcast) = broadcast_for_binary_ops(&lhs, &rhs);
// Now we can safely zip and compare
Zip::from(&lhs_broadcast)
.and(&rhs_broadcast)
Expand Down
Loading