fix(llama-index): use the correct instrumentation point #2807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giovanni Liva <[email protected]>
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 56144b6 in 1 minute and 3 seconds
More details
- Looked at
22lines of code in1files - Skipped
0files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. packages/opentelemetry-instrumentation-llamaindex/opentelemetry/instrumentation/llamaindex/__init__.py:41
- Draft comment:
Ensure the dependency change to 'llama-index-core' aligns with SDK requirements. This update is critical as it triggers instrumentation only when the core package is present. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =20%<= threshold50%
The comment is related to a dependency change, specifically mentioningllama-index-core. It suggests ensuring alignment with SDK requirements, which is a general cautionary note. The comment does not provide a specific code suggestion or identify a specific issue with the change. It seems to be more of a reminder or caution, which violates the rule against making purely informative comments.
2. packages/opentelemetry-instrumentation-llamaindex/opentelemetry/instrumentation/llamaindex/__init__.py:58
- Draft comment:
Verify that checking version for 'llama-index-core' is intended. The updated condition ensures the dispatcher instrumentation is used only for core versions >= 0.10.20. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =30%<= threshold50%
The comment is asking the PR author to verify their intention regarding a version check forllama-index-core. This falls under the rule of not asking the author to confirm their intention. However, it does provide specific information about the condition change, which could be useful if it were rephrased as a suggestion or observation rather than a request for verification.
3. packages/opentelemetry-instrumentation-llamaindex/opentelemetry/instrumentation/llamaindex/__init__.py:41
- Draft comment:
Updated the dependency from 'llama-index' to 'llama-index-core' so that instrumentation depends on the correct package. Ensure that this matches the installed package and its versioning. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
This comment is related to a dependency change, which is not allowed according to the rules. The comment asks the author to ensure that the dependency matches the installed package and its versioning, which is not specific enough to be useful. Therefore, this comment should be removed.
4. packages/opentelemetry-instrumentation-llamaindex/opentelemetry/instrumentation/llamaindex/__init__.py:58
- Draft comment:
Switched the version check to use 'llama-index-core' so that it uses the correct package version for instrumentation. Verify that the version semantics on 'llama-index-core' align as expected. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
The comment is asking the PR author to verify the version semantics, which is against the rules. It does not provide a specific suggestion or point out a specific issue with the code. Therefore, it should be removed.
Workflow ID: wflow_Yf0i2zWUkQ1IbdmI
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Another possibility would be to create two Instruments: |
|
Sounds like a great plan actually! |
e074ef4 to
1371782
Compare
|
Hey @nirga 👋 I've implemented what we discussed :) the PR is ready for another round of review |
nirga
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2799
feat(instrumentation): ...orfix(instrumentation): ....The instrumentation only attaches to
*.corepackages. Therefore, it should be the dependency used to decide if the instrumentation is triggered.