Updates Docker Client API version 1.24 -> 1.44#12255
Conversation
Oldest supported version as of Docker 29.0
|
According to https://github.com/moby/moby/releases/tag/docker-v29.0.0:
It would probably be better to update this PR so the project no longer uses the deprecated API, and replace it with the recommended current one, since the old one is probably no longer supported. @TheLonelyGhost what does your testing show? |
|
Is there a reason to hard code the API version instead of using WithAPIVersionNegotiation? I think the negotiation was introduced in Docker 1.24 and Traefik predates that, so it was not considered at the time. |
|
@vincentbernat I removed the hardcoded API version in PR #12256 and replaced it with |
|
Would be great if this could be merged as some kind of priority. It appears that most people that are patching their systems have all Traefik services fail. I am sure I am not the only one that wasted quite some time to jump through all the hoops to find that the root cause is Traefik's hardcoded API version. |
This PR should not be merged, it repeats the same mistake that created the current situation. #12256 is the proper fix. |
Thanks - whatever is the final fix. It seems to have a massive effect on docker systems out there. |
|
Hello @TheLonelyGhost, Thanks for this contribution! We had a lot of contributions to fix #12253, and we decided to keep #12256. |
Oldest supported version as of Docker 29.0 is 1.44. Fixes #12253, but in a manner that introduces backward incompatibilities.
What does this PR do?
Updates Docker Client API to the minimum version to be compatible with the latest released version of Docker CE (v1.24 -> v1.44).
Motivation
Am also suffering from shared issue with #12253.
More
Additional Notes