Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Updates Docker Client API version 1.24 -> 1.44#12255

Closed
TheLonelyGhost wants to merge 1 commit into
traefik:masterfrom
TheLonelyGhost:fix/docker-client-out-of-date
Closed

Updates Docker Client API version 1.24 -> 1.44#12255
TheLonelyGhost wants to merge 1 commit into
traefik:masterfrom
TheLonelyGhost:fix/docker-client-out-of-date

Conversation

@TheLonelyGhost

Copy link
Copy Markdown

Oldest supported version as of Docker 29.0 is 1.44. Fixes #12253, but in a manner that introduces backward incompatibilities.

What does this PR do?

Updates Docker Client API to the minimum version to be compatible with the latest released version of Docker CE (v1.24 -> v1.44).

Motivation

Am also suffering from shared issue with #12253.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Oldest supported version as of Docker 29.0
@AndrewSav

Copy link
Copy Markdown
Contributor

According to https://github.com/moby/moby/releases/tag/docker-v29.0.0:

The Go module github.com/docker/docker is deprecated in favor of github.com/moby/moby/client and github.com/moby/moby/api.

It would probably be better to update this PR so the project no longer uses the deprecated API, and replace it with the recommended current one, since the old one is probably no longer supported.

@TheLonelyGhost what does your testing show?

@vincentbernat

Copy link
Copy Markdown
Contributor

Is there a reason to hard code the API version instead of using WithAPIVersionNegotiation? I think the negotiation was introduced in Docker 1.24 and Traefik predates that, so it was not considered at the time.

@felixbuenemann

felixbuenemann commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

@vincentbernat I removed the hardcoded API version in PR #12256 and replaced it with WithAPIVersionNegotiation().

@leogaggl

Copy link
Copy Markdown

Would be great if this could be merged as some kind of priority.

It appears that most people that are patching their systems have all Traefik services fail.

I am sure I am not the only one that wasted quite some time to jump through all the hoops to find that the root cause is Traefik's hardcoded API version.

@saltydk

saltydk commented Nov 12, 2025

Copy link
Copy Markdown

Would be great if this could be merged as some kind of priority.

It appears that most people that are patching their systems have all Traefik services fail.

I am sure I am not the only one that wasted quite some time to jump through all the hoops to find that the root cause is Traefik's hardcoded API version.

This PR should not be merged, it repeats the same mistake that created the current situation. #12256 is the proper fix.

@leogaggl

Copy link
Copy Markdown

Would be great if this could be merged as some kind of priority.
It appears that most people that are patching their systems have all Traefik services fail.
I am sure I am not the only one that wasted quite some time to jump through all the hoops to find that the root cause is Traefik's hardcoded API version.

This PR should not be merged, it repeats the same mistake that created the current situation. #12256 is the proper fix.

Thanks - whatever is the final fix. It seems to have a massive effect on docker systems out there.

@rtribotte

Copy link
Copy Markdown
Member

Hello @TheLonelyGhost,

Thanks for this contribution!

We had a lot of contributions to fix #12253, and we decided to keep #12256.
We are closing this PR accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error response from daemon: client version 1.24 is too old

8 participants