Changes to use Moodle's qbank exporttoxml script instead of custom code #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coderunner had it's own script to download the export of a single question. But to avoid a lot of custom code and use standard Moodle script, deleting the coderunner's exportone.php and using Moodle's instead.
|
Nice! Thanks Anupama. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Richard,
While testing we found that the 'Export this question' link on questiontestrun.php is throwing the below mentioned deprecation error. And also, noticed Coderunner was using it's own script to download the export of a single question. But, since we now have standard Moodle script and to avoid a lot of custom code, deleting the coderunner's exportone.php and using Moodle's script instead. Could you please review the fix if that looks good?
I was not sure whether to send the pull request on master or development branch. Did it on master branch.
Kindly let me know if you want me to send the patch on development branch, will change it accordingly.
Error:
Class 'question_edit_contexts' has been renamed for the autoloader and is now deprecated. Please use 'core_question\local\bank\question_edit_contexts' instead.
line 153 of /lib/classes/component.php: call to debugging()
line 57 of /question/type/coderunner/exportone.php: call to core_component::classloader()
Warning: Undefined property: stdClass::$status in /var/www/html/moodle/question/format.php on line 962