Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add generate crate to workspace & adjust to new clippy lints #4192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 8, 2025
Merged

add generate crate to workspace & adjust to new clippy lints #4192

merged 2 commits into from
Feb 8, 2025

Conversation

amaanq
Copy link
Member

@amaanq amaanq commented Feb 8, 2025

CI is failing because of the new clippy lint, which suggests to use write! over appending a string with format, to avoid an extra allocation. Additionally, the generate crate was missing in the workspace members list.

@amaanq amaanq mentioned this pull request Feb 8, 2025
Merged
@amaanq amaanq merged commit 74d7ca8 into tree-sitter:master Feb 8, 2025
16 of 19 checks passed
@clason
Copy link
Contributor

clason commented Feb 8, 2025 •
edited
Loading

Can we not merge PRs with failing CI? Especially a PR that is supposed to fix CI?

@amaanq
Copy link
Member Author

amaanq commented Feb 8, 2025 •
edited
Loading

While I agree w/ that sentiment - the issue isn't in this repo, but downstream in nvim-treesitter. It looks like the razor parser in nvim-treesitter isn't marked as requiring npm install to generate from source.

@clason
Copy link
Contributor

clason commented Feb 8, 2025

Yes, and then you can ping me so I can fix it.

@amaanq
Copy link
Member Author

amaanq commented Feb 8, 2025

Nope, the error is from tree-sitter-c-sharp.

Error: Cannot find module 'tree-sitter-c-sharp/grammar'
Require stack:
- C:\Users\runneradmin\AppData\Local\Temp\nvim\tree-sitter-razor\grammar.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1140:15)
    at Module._load (node:internal/modules/cjs/loader:981:27)
    at Module.require (node:internal/modules/cjs/loader:1231:19)
    at require (node:internal/modules/helpers:177:18)
    at Object.<anonymous> (C:\Users\runneradmin\AppData\Local\Temp\nvim\tree-sitter-razor\grammar.js:10:16)
    at Module._compile (node:internal/modules/cjs/loader:1364:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    at Module.load (node:internal/modules/cjs/loader:1203:32)
    at Module._load (node:internal/modules/cjs/loader:1019:12)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:203:29) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\nvim\\tree-sitter-razor\\grammar.js'
  ]
}

That's not a c-sharp grammar issue

@clason clason added the ci:backport release-0.25 Backport label label Feb 9, 2025
@tree-sitter-ci-bot
Copy link

Successfully created backport PR for release-0.25:

@tree-sitter-ci-bot tree-sitter-ci-bot bot mentioned this pull request Feb 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillLillis WillLillis WillLillis approved these changes

Assignees
No one assigned
Labels
ci:backport release-0.25 Backport label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amaanq @clason @WillLillis