fix(bindings): improve zig dependency fetching logic #4730
Merged
+32
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, including a tree-sitter parser as a dependency in a zig project and running `zig build test` on the project will fetch the zig-tree-sitter dependency declared by the parser. This is a problem because (a) consumers may not want this dependency for whatever reason and (b) due to how often Zig breaks everything and how scarcely most tree-sitter parsers are updated, the zig-tree-sitter version pinned by the parser module will often be outdated and broken. The workaround I used was taken from https://ziggit.dev/t/11234
9171d15 to
ca483b1
Compare
nvlled
reviewed
Aug 25, 2025
WillLillis
approved these changes
Aug 27, 2025
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, including a tree-sitter parser as a dependency in a zig project and running
zig build teston the project will fetch the zig-tree-sitter dependency declared by the parser. This is a problem because (a) consumers may not want this dependency for whatever reason and (b) due to how often Zig breaks everything and how scarcely most tree-sitter parsers are updated, the zig-tree-sitter version pinned by the parser module will often be outdated and broken.The workaround I used was taken from https://ziggit.dev/t/11234.
I also noticed that we were unconditionally replacing the files and fixed that while I was at it.
/cc @nvlled