Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add MaxHeap #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 16, 2018
Merged

Add MaxHeap #167

merged 4 commits into from
Aug 16, 2018

Conversation

kersov
Copy link
Contributor

@kersov kersov commented Aug 13, 2018

No description provided.

@kersov kersov mentioned this pull request Aug 13, 2018
Closed
@trekhleb
Copy link
Owner

@okersov thank you for your PR!
Could you please fix the following:

  • MinHeap must not extend MaxHip. Rather both must extend Heap.js
  • All common functionality must be moved to Heap.js

@codecov-io
Copy link

codecov-io commented Aug 15, 2018 •
edited
Loading

Codecov Report

Merging #167 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #167    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files         124    130     +6     
  Lines        2346   2451   +105     
  Branches      396    420    +24     
======================================
+ Hits         2346   2451   +105
Impacted Files Coverage Δ
src/data-structures/heap/MinHeap.js 100% <ø> (ø) ⬆️
src/data-structures/heap/Heap.js 100% <100%> (ø)
src/data-structures/heap/MaxHeap.js 100% <100%> (ø)
...rc/algorithms/math/complex-number/ComplexNumber.js 100% <0%> (ø) ⬆️
...hms/math/fourier-transform/fastFourierTransform.js 100% <0%> (ø)
...math/fourier-transform/discreteFourierTransform.js 100% <0%> (ø)
src/algorithms/math/radian/degreeToRadian.js 100% <0%> (ø)
src/algorithms/math/radian/radianToDegree.js 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9111568...87e8c87. Read the comment docs.

@kersov
Copy link
Contributor Author

kersov commented Aug 15, 2018

Hello @trekhleb,
I have updated PR according to your comment. Please check it.
Also, I improved jsdoc comments a bit.

@trekhleb trekhleb changed the base branch from master to max-heap August 16, 2018 15:18
@trekhleb
Copy link
Owner

Thanks @okersov

@trekhleb trekhleb merged commit 10e633f into trekhleb:max-heap Aug 16, 2018
harshes53 pushed a commit to harshes53/javascript-algorithms that referenced this pull request Dec 6, 2018
@kersov @harshes53
Add MaxHeap (trekhleb#167)
f4d4770 
* Add MaxHeap

* Add parent class for MinHeap and MaxHeap
shoredata pushed a commit to shoredata/javascript-algorithms that referenced this pull request Mar 28, 2019
@kersov @shoredata
Add MaxHeap (trekhleb#167)
993294f 
* Add MaxHeap

* Add parent class for MinHeap and MaxHeap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kersov @trekhleb @codecov-io