Fix test_glob #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
== operator for lists relies on the order of elements in the list. cmp() does not. In my case, on Linux Mint, python3.6 glob() returned list had items in reverse order then expected in the test. The glob() doc doesn't specify specific ordering. cmp() for list objects doesn't rely on the order of items and produces the right result.
|
Hi @Psimage. Thank you for the PR. Sure, let's sort the lists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==operator for lists relies on the order of elements in the list.In my case, on Linux Mint, python3.6
glob()returned list had items in reverse order then expected in the test.The
glob()doc doesn't specify items ordering.Lets sort both lists before comparison using
sorted()built-in.