Small fixes in prep for v4 self-hosting #2018
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis update modifies several GitHub Actions workflows and a TypeScript validator. In the workflows, a new job ( Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant GitHub Actions
participant Registry
Developer->>GitHub Actions: Push code / trigger workflow
GitHub Actions->>GitHub Actions: Run typecheck
GitHub Actions->>GitHub Actions: Run units
GitHub Actions->>GitHub Actions: Run publish-worker
GitHub Actions->>GitHub Actions: Run publish-worker-v4 (after typecheck & units)
%% The step to push 'v3' tag is now commented out in both publish-worker workflows
%% No push to Registry with 'v3' tag occurs
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
✨ No issues found! Your code is sparkling clean! ✨ |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/webapp/app/runEngine/validators/triggerTaskValidator.ts (1)
49-49: Improved entitlement validation logicThis change refines the validation to only return an error when access is explicitly denied, rather than also returning an error when entitlement information is missing or indeterminate. This makes the validation more forgiving and is consistent with the "entitlement validation fix" mentioned in the PR objectives.
Consider adding a comment to explain the intended behavior:
+ // Only return an error when access is explicitly denied if (result && result.hasAccess === false) {
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/publish-worker-re2.yml(1 hunks).github/workflows/publish-worker.yml(1 hunks).github/workflows/publish.yml(1 hunks)apps/webapp/app/runEngine/validators/triggerTaskValidator.ts(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/publish.yml
74-74: could not read reusable workflow file for "./.github/workflows/publish-worker-v4.yml": open /home/jailuser/git/.github/workflows/publish-worker-v4.yml: no such file or directory
(workflow-call)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
- GitHub Check: typecheck / typecheck
- GitHub Check: units / 🧪 Unit Tests
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (2)
.github/workflows/publish-worker-re2.yml (1)
88-95: Appropriate change for v4 preparationThis change disables the automatic tagging of Docker images as 'v3', which aligns with the PR objective of preparing for v4 self-hosting. By commenting out this step rather than removing it, you've preserved the code for reference while preventing creation of new v3-tagged images.
.github/workflows/publish-worker.yml (1)
80-87: Appropriate change for v4 preparationThis change disables the automatic tagging of Docker images as 'v3', consistent with the similar change in
publish-worker-re2.ymland the overall PR objective of preparing for v4 self-hosting.
|
Fixes:
Summary by CodeRabbit
Chores
Bug Fixes