The bat syntax regression test fails:

[bat error]: /home/runner/work/syntect/syntect/bat/assets/syntaxes/02_Extra/Jsonnet/jsonnet.sublime-syntax: Invalid YAML file syntax: while parsing a quoted scalar, found unknown escape character at byte 2838 line 93 column 14

It looks like the jsonnet.sublime-syntax file has actual invalid syntax (\') on line 93 and 117. Online tools like https://www.yamllint.com/ and https://yamlchecker.com/ also report the same error.

This PR introduces a regression for bat, but only because bat's regression test includes a file with seemingly invalid syntax. How do we resolve this?

Oop, I think merging this was a breaking change. I was hoping to get out a 5.3.0 release 😅

My bad, I probably rushed a bit because I felt that we should probably have upgraded this dependency a while ago... Would it make sense to push a commit reverting this PR, make the minor release, then revert the revert? 😅

I think that should work out totally fine 👍

Just to be clear, I don't have cargo publish permissions for syntect so it will need one of the other maintainers to perform the release

@keith-hall I can add you as owner for https://crates.io/crates/syntect so you can make releases on your own. If you'd like?

CC other owners @trishume @robinst

Sure, that could be convenient, thanks 👍 do we have any documentation on the release process/checklist for syntect? I had a quick look but didn't see anything

I invited you as owner now.

I don't think there is a checklist, but I think doing this is sufficient:

• Ensure CI passes for the commit you want to publish
• checkout that commmit locally
• cargo publish
• git tag and push the tag

My recommendation is to not have any long-term auth token around. Best would be if we enabled trusted publishing. Here is a minimal example from one of my projects: https://github.com/Enselic/snapshot-testing/blob/main/.github/workflows/release.yml. But that is a nice-to-have and not blocking any releases.

Thanks, release has been made. I noticed we have a Release workflow in syntect, but when I tried it, it didn't work:

The workflow is not valid. .github/workflows/Release.yml (Line: 25, Col: 40): Invalid input, one_time_crates_io_token_secret is not defined in the referenced workflow.

So I published manually for now. And raised a new PR to re-apply yaml-rust2: #602