Thanks to visit codestin.com
Credit goes to github.com

Skip to content

build: normalize install tree ownership and permissions#8803

Merged
mattwittwer merged 3 commits into
mainfrom
mwittwer/normalize_nvidia_user_ownership
Jun 4, 2026
Merged

build: normalize install tree ownership and permissions#8803
mattwittwer merged 3 commits into
mainfrom
mwittwer/normalize_nvidia_user_ownership

Conversation

@mattwittwer
Copy link
Copy Markdown
Contributor

@mattwittwer mattwittwer commented May 26, 2026

What does the PR do?

  • Replace chmod -R a+rw on the install tree with an explicit symbolic
    mode (u+rwX,go+rX,go-w) in server/build.py:finalize_build.
  • Drop --chown=1000:1000 from the generated COPY directives in
    server/build.py and server/compose.py. Install artifacts under
    /opt/tritonserver/ remain owned by root; the triton-server runtime
    user (UID 1000) accesses them via group/other permission bits.
  • Remove the now-redundant RUN chown triton-server:triton-server /opt/tritonserver/... follow-ups in compose.py for backends,
    repoagents, and caches.
  • Update the comment block above ENV TRITON_SERVER_USER=triton-server
    to match the new ownership model.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Test plan:

  • CI Pipeline ID:

52956551

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@mattwittwer mattwittwer self-assigned this May 26, 2026
whoisj
whoisj previously approved these changes Jun 1, 2026
Copy link
Copy Markdown
Contributor

@whoisj whoisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this has been tested? It looks like it should work, but I'll be counting on you to have validated it.

Thanks for getting this done.

yinggeh
yinggeh previously approved these changes Jun 2, 2026
@mattwittwer mattwittwer dismissed stale reviews from yinggeh and whoisj via 900d536 June 3, 2026 21:17
Copy link
Copy Markdown
Contributor

@whoisj whoisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattwittwer mattwittwer merged commit 5dfefde into main Jun 4, 2026
3 checks passed
@mattwittwer mattwittwer deleted the mwittwer/normalize_nvidia_user_ownership branch June 4, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants