security: redact OpenAI restriction secrets in logs#8810
Open
dfgvaetyj3456356-hash wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redacts
--openai-restricted-apiheader values from the OpenAI frontend startup log while preserving the configured header names and the internal values used for request authentication.The restriction values are shared secrets for protected API groups. The current startup log prints
RestrictionDict()directly, which includes both the header key and the expected value. In deployments where stdout/container logs are available to operators or log aggregation readers, this can disclose the same value required to access restricted endpoints such as model listing and model load/unload.Changes
RestrictedFeatures.RedactedRestrictionDict()for log-safe reporting.Verification
I could not run the focused pytest target in this local environment because the test conftest imports the
tritonserverPython package, which is not installed here.