Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

fredericohpandolfo
Copy link
Contributor

@fredericohpandolfo fredericohpandolfo commented Dec 30, 2022

Moved "default entry" to last position, to prevent "Module not found: Default condition should be last one" errors.

What was a problem

Importing "ts-graphviz" resulted in "Module not found: Default condition should be last one" error.

How this PR fixes the problem

This fix correct the order of "Default condition"

Check lists (check x in [ ] of list items)

  • [ x] Test passed
  • [x ] Coding style (indentation, etc)

Additional Comments (if any)

{Please write here}

Moved "default entry" to last position, to prevent "Module not found: Default condition should be last one" errors.
@kamiazya
Copy link
Member

@fredericohpandolfo Thanks for your contribution.

LGTM!

I have checked and found that the error occurs with webpack.

@kamiazya kamiazya self-assigned this Dec 31, 2022
@kamiazya kamiazya added the bug Something isn't working label Dec 31, 2022
@kamiazya kamiazya merged commit d3cca21 into ts-graphviz:main Dec 31, 2022
@kamiazya
Copy link
Member

@all-contributors please add @fredericohpandolfo for bug.

@allcontributors
Copy link
Contributor

@kamiazya

I've put up a pull request to add @fredericohpandolfo! 🎉

@kamiazya
Copy link
Member

kamiazya commented Jan 1, 2023

The e2e test with Deno failed in CI, we will check the cause and release it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants