Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix event handler removal in dropdown/carousel dispose #33000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 12, 2021
Merged

Fix event handler removal in dropdown/carousel dispose #33000

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
109db98
Fix event handler removal in carousel dispose
kyletsang Feb 8, 2021
956c292
Fix event handler removal in dropdown dispose
kyletsang Feb 8, 2021
6bbaefc
Test event handlers in scrollspy dispose
kyletsang Feb 8, 2021
4d884cf
Test event handlers in toast dispose
kyletsang Feb 8, 2021
2166472
Test event handlers in tooltip dispose
kyletsang Feb 8, 2021
0e4eac9
Merge branch 'main' into fix/dropdown-dispose
XhmikosR Feb 11, 2021
344f287
Update .bundlewatch.config.json
XhmikosR Feb 11, 2021
90b9a2a
Merge branch 'main' into fix/dropdown-dispose
rohit2sharma95 Feb 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test event handlers in toast dispose
  • Loading branch information
@kyletsang
kyletsang committed Feb 8, 2021
commit 4d884cf1ae39cc62c9e7d69d4926e76af49336a9
5 changes: 5 additions & 0 deletions js/tests/unit/toast.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,13 +274,18 @@ describe('Toast', () => {
fixtureEl.innerHTML = '<div></div>'

const toastEl = fixtureEl.querySelector('div')
spyOn(toastEl, 'addEventListener').and.callThrough()
spyOn(toastEl, 'removeEventListener').and.callThrough()

const toast = new Toast(toastEl)

expect(Toast.getInstance(toastEl)).toBeDefined()
expect(toastEl.addEventListener).toHaveBeenCalledWith('click', jasmine.any(Function), jasmine.any(Boolean))

toast.dispose()

expect(Toast.getInstance(toastEl)).toBeNull()
expect(toastEl.removeEventListener).toHaveBeenCalledWith('click', jasmine.any(Function), jasmine.any(Boolean))
})

it('should allow to destroy toast and hide it before that', done => {
Expand Down