Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

nickyod
Copy link

@nickyod nickyod commented Feb 14, 2021

Fix bug where list-group-items rendered in a card element
with a background-color do not inherit the card background
and are not visible.

Fixes #33084

Fix bug where list-group-items rendered in a card element
with a background-color do not inherit the card background
and are not visible.
@nickyod nickyod requested a review from a team as a code owner February 14, 2021 16:21
@twbs twbs deleted a comment from nickyod Feb 15, 2021
@ffoodd
Copy link
Member

ffoodd commented Feb 15, 2021

IMHO it'd be more consistent to set color properly in .list-group-item instead.

Utilities should not influence how we're designing components—mostly because your use case could better be solved by setting .bg-* on list group items.

@mdo
Copy link
Member

mdo commented Feb 26, 2021

Agreed with @ffoodd.

@ffoodd
Copy link
Member

ffoodd commented Feb 26, 2021

Great so in fact, it's as simple as setting a different value than null for $list-group-color.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

list-group-items within cards do not inherit background-color
4 participants