-
-
Notifications
You must be signed in to change notification settings - Fork 79.2k
Docs: add Border radius section for Input group #40776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: add Border radius section for Input group #40776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with the implementation, waiting for another review.
I'm not opposed, but I'll push some edits to explain why this section is here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the collective work here 💪
Just used the .d-none
class and refined some property values in e3d9b82
Description
I added a Border radius section in the Input group docs to explicitly show how that style is applied to the children elements.
I might have given too much importance to the section because I wanted the behavior to be clear to newcomers and avoid any confusion, but I could see how the same information could be delivered just by adding a single line in the Basic example section.
Please let me know if there is anything I can improve with my solution.
Type of changes
Checklist
npm run lint
)Live previews
Related issues
Closes #40763