Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

TommasoAllegretti
Copy link
Contributor

@TommasoAllegretti TommasoAllegretti commented Aug 27, 2024

Description

I added a Border radius section in the Input group docs to explicitly show how that style is applied to the children elements.

I might have given too much importance to the section because I wanted the behavior to be clear to newcomers and avoid any confusion, but I could see how the same information could be delivered just by adding a single line in the Basic example section.

Please let me know if there is anything I can improve with my solution.

Type of changes

  • Documentation enhancement (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #40763

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the implementation, waiting for another review.

@mdo
Copy link
Member

mdo commented Apr 9, 2025

I'm not opposed, but I'll push some edits to explain why this section is here.

@mdo mdo added this to v5.3.6 Apr 9, 2025
@github-project-automation github-project-automation bot moved this to To do in v5.3.6 Apr 9, 2025
@julien-deramond julien-deramond moved this from To do to Review in progress in v5.3.6 Apr 9, 2025
@julien-deramond julien-deramond self-requested a review April 9, 2025 18:24
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the collective work here 💪
Just used the .d-none class and refined some property values in e3d9b82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Outer right border radius not applied to datalist in an input group
4 participants