Fix Ignoring dynamically Globals failing test#38
Open
raffaelecarelle wants to merge 2 commits into
Open
Conversation
Implemented a new test suite to validate Twig global variables. Introduced `TemplateDataExtension` to manage global variables, and updated `twig-loader` to use this extension. Added corresponding end-to-end test cases and sample Twig template.
7b34b6e to
1ab2143
Compare
Contributor
Author
|
It would usefull add in twig {% phpstan_ignore "variable.undefined" %} thats add // @phpstan-ignore "variable.undefined" comment up to variable to be ignored. Any suggestion @ruudk? |
Contributor
|
Wouldn't this be solved with the baseline feature? |
Contributor
Author
|
most likely yes. With Baseline I can add to ignoreErrors the variable.undefined error I want to |
Contributor
|
I was thinking about this. It would be solved if Symfony always passes the current request as It's kind of weird that they have I'll try to do some research on this and see if I can raise an issue for it upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.