Add Dockerfile and related changes to build the Docker image #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dprothero
reviewed
Jun 19, 2018
| @@ -45,3 +45,14 @@ clean: | |||
|
|
|||
| nopyc: | |||
| find . -name \*.pyc -delete | |||
|
|
|||
| API_DEFINITIONS_SHA=$(shell git log --oneline | grep Regenerated | head -n1 | cut -d ' ' -f 5) | |||
There was a problem hiding this comment.
Should we add a prefix like apidefs to this to distinguish it from other SHA's?
There was a problem hiding this comment.
I think so.. what do you think about twilio/twilio-python:apidefs-<sha>?
|
We should probably add some notes to the README on how to use the docker image for the purpose of exploring the helper library. |
|
@dprothero I added the README text here, what do you think? If that's enough I'll add in the other repos as well. |
cjcodes
approved these changes
Jun 29, 2018
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
This PR adds the Dockerfile and related files to build the lib Docker image. This image will be used mainly by Tricorder to generate further Tricorder worker images with the specific lib version.
The tags used in the Docker images are the version (from the release tag) and the api-definitions SHA from the release.
TODO: