Queue support for twilio's python library #76
Conversation
|
|
||
|
|
||
| class Leave(Verb): | ||
| """Signals the call to leave it's queue |
There was a problem hiding this comment.
fixed in commit 2f73bd2
|
Does dequeue() make more sense as a property of a Member object, instead of on the list resource? eg member.dequeue() instead of members.dequeue(member)? If you try to POST to dequeue a member and do not include a Twiml URL, you get a 400 'Url is required' bad request, indicating this should be a mandatory parameter on the method. |
| """ | ||
| Returns a list of :class:`Member` resources in the given queue | ||
|
|
||
| :param queue_sid: Conference this participant is part of |
There was a problem hiding this comment.
should say "Queue this participant is a part of"?
There was a problem hiding this comment.
Fixed in commit 2f73bd2
|
|
||
| def __init__(self, name, **kwargs): | ||
| super(Queue, self).__init__(**kwargs) | ||
| self.body = name |
There was a problem hiding this comment.
What is body? It's not documented in the above documentation.
There was a problem hiding this comment.
Sorry - just realized this is Twiml.
There was a problem hiding this comment.
Fixed in commit 866eba5
|
I think dequeue makes more sense on the list resource. A dequeue doesn't always need a member's call_sid members.dequeue(member_call_sid) for dequeuing a specific call, members.dequeue() for dequeuing the first call on the queue. |
|
I agree with Dan that dequeue makes more sense on the list resource. However, Kevin is right that the dequeue method needs to take a TwiML url as the first argument. |
|
See pull request #77 |
Adds the MIT licence header
This includes both twiml and restAPI support