fix return types - #18
Closed
ReenigneArcher wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Could someone please address this PR? To illustrate why it's an issue, here is a screenshot. |
Contributor
Author
|
bump |
1 similar comment
Contributor
Author
|
bump |
Contributor
Author
|
@felixnorden sorry for the direct ping, but could you or someone take a look at this? |
Contributor
|
Hey, no worries, I'll ping someone among my former colleagues and they can hopefully help out! @ReenigneArcher 🤝 @husnjak could you have a look at this if time permits? |
Contributor
|
Hello, thank you for your PR! |
Contributor
Author
|
Handled in #33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes return types in
wrapper.py.api_requestdid not return aResponseobject, but instead astr_compose_requestdid not return aRequestobject, but instead adict