Conversation
Kafka's schema defaults ResponsePartitionLimit to 2000; the definition said 200. The field is not tagged, so every request built through Default() sent the wrong limit: silently 10x smaller pages (and 10x the round trips) on large clusters. Found by diffing generate/definitions against Kafka's message JSONs.
Plain gofmt only; regenerate. Formatting-only change to generated.go.
KIP-1066 (cordoned log dirs), released in Kafka 4.3: DescribeLogDirs v5 adds IsCordoned per log dir, BrokerHeartbeat v2 adds the tagged CordonedLogDirs request field (broker-internal API). These are the only two request version changes between 4.2 and 4.3 (verified by diffing every message JSON between the release tags).
The only request version changes in 4.3 are DescribeLogDirs v5 (broker) and BrokerHeartbeat v2 (controller), both KIP-1066; verified by diffing every message JSON between the 4.2.0 and 4.3.0 tags. Stable now returns 4.3.
…ned) DescribedLogDir never carried the volume-level response fields: TotalBytes/UsableBytes arrived in DescribeLogDirs v4 (Kafka 3.3) and IsCordoned in v5 (Kafka 4.3, KIP-1066).
IsCordoned is always false; kfake does not model cordoned log dirs.
The only Kafka 4.3 KIP with client protocol work: DescribeLogDirs v5 and BrokerHeartbeat v2. The remaining 4.3 KIPs are Java Streams, Connect, MirrorMaker, broker-internal, or configs (inherently supported).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.