Issue #344: Add basic Set support (ADD and DELETE operations) #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whimzyLive
requested changes
Sep 30, 2023
| ); | ||
| } | ||
| }); | ||
| // THIS CHECK IS NOT NEEDED |
There was a problem hiding this comment.
From memory the reason this check was here was due to DynamoDB itself didn't support declaring multiple condition on same attribute within a expression..
With your below example... it would have created an incorrect query expression that would fail when executing against DynamoDB.
Not sure if this has changed since the time it was implemented. Would love to see some references proving this is now supported.
There was a problem hiding this comment.
im currently running this raw :
TransactWriteItems{
"TransactItems": [
{
"Update": {
"TableName": "test",
"Key": {
"PK": {
"S": "UserId#111"
},
"SK": {
"S": "RUNNING_TASKS"
}
},
"ExpressionAttributeNames": {
"#runningTaskIds": "runningTaskIds"
},
"ExpressionAttributeValues": {
":runningTaskIds": {
"SS": ["12", "34"]
},
":zero": {
"N": "0"
}
},
"ConditionExpression":
"attribute_not_exists(#runningTaskIds) OR size(#runningTaskIds) = :zero",
"UpdateExpression": "ADD #runningTaskIds :runningTaskIds"
}
}
]
}
packages/core/src/classes/expression/expression-input-parser.ts
Outdated
Show resolved
Hide resolved
|
@whimzyLive anything else needed here? can we rerun the automated checks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#344