Add implicit Attribute.From instances
#926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add implicit `Attribute.From` instances for integer primitives to be used in `Attribute[Long]`s and for `Seq`s of integer primitives to be used in `Attribute[Seq[Long]]`s. Add implicit derivation of `Attribute.From[Seq[V], Seq[K]]` given an implicit `Attribute.From[V, K]`. Make input type of `Attribute.From` contravariant.
8adc92f to
d130106
Compare
iRevive
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add implicit
Attribute.Frominstances for integer primitives to be used inAttribute[Long]s and forSeqs of integer primitives to be used inAttribute[Seq[Long]]s.Add implicit derivation of
Attribute.From[Seq[V], Seq[K]]given an implicitAttribute.From[V, K].Make input type of
Attribute.Fromcontravariant.