Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix KindTransformer instances #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2025
Merged

Fix KindTransformer instances #979

merged 1 commit into from
Jun 7, 2025

Conversation

NthPortal
Copy link
Contributor

Remove unsound KindTransformer instance for StateT.

Add KindTransformer instance for WriterT.

Lighten context bound on KindTransformer instance for Resource
from MonadCancelThrow to MonadCancel.

@NthPortal
Fix KindTransformer instances
5d89790 
Remove unsound `KindTransformer` instance for `StateT`.

Add `KindTransformer` instance for `WriterT`.

Lighten context bound on `KindTransformer` instance for `Resource`
from `MonadCancelThrow` to `MonadCancel`.
@NthPortal NthPortal requested a review from iRevive May 28, 2025 16:41
@NthPortal NthPortal added breaking The changes are semantically or binary breaking module:core Features and improvements to core module labels May 28, 2025
@mergify mergify bot added the tracing Improvements to tracing module label May 28, 2025
@NthPortal
Copy link
Contributor Author

@iRevive this one should be pretty straightforward I think. technically breaking because it removes the StateT instance, but that wasn't sound anyway so... yeah. I didn't bother adding tests for KindTransformer outside the context of Tracer as we're hopefully moving it out soon, but if we somehow end up keeping it here, the laws are already written and can be added easily later

@NthPortal NthPortal merged commit 7e16b18 into typelevel:main Jun 7, 2025
11 checks passed
@NthPortal NthPortal deleted the KindTransformer-fixes/PR branch June 7, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iRevive iRevive iRevive approved these changes

Assignees
No one assigned
Labels
breaking The changes are semantically or binary breaking module:core Features and improvements to core module tracing Improvements to tracing module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NthPortal @iRevive