Draft
Conversation
gioboa
requested changes
Feb 24, 2026
Collaborator
gioboa
left a comment
There was a problem hiding this comment.
is this PR still valid or is it abandoned?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
This change fixes SQLite losing column collations during loadTables() by reading COLLATE clauses from the stored table SQL. The query runner now parses column definitions in sqlite_master.sql and assigns the extracted collation to TableColumn.collation, preserving NOCASE (and other collations) across schema syncs. Driver-specific SQL normalization ensures consistent parsing for both sqlite and sqljs.
Why needed:
Without this, a table rebuilt during synchronize() drops collations because they are not captured from the existing table definition.
How verified:
Code inspection of loadTables() and schema sync flow; no automated tests added.
Current behavior:
Collations (e.g. COLLATE NOCASE) are lost after schema changes.
New behavior:
Collations are preserved when loadTables() reads the current schema.
Fixes #11907
Pull-Request Checklist
masterbranchFixes #00000tests/**.test.ts)docs/docs/**.md)