Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bug: [no-unnecessary-template-expression] Should not report when expression includes comment #10434

Closed
@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.7.2&fileType=.ts&code=AYKAJA3g9AVABASwHYBcCmqEHskEMA2cAxlgLakYpwxRwDkdAviAHRvADcQA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Jge1tiacTJTIAhtEK18iALbF4QifQAexaIMocm6KImjQO0SODABfEEaA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

`
${/* intentional comment */ ''}
...`;

ESLint Config

module.exports = {
  "rules": {
    "@typescript-eslint/no-unnecessary-template-expression": "error"
  }
}

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true
  }
}

Expected Result

No error, as there's no other way to include the comment there.

Actual Result

Template literal expression is unnecessary and can be simplified. 2:1 - 2:32

Additional Info

Discovered in TypeHero, thanks for letting me do user research on you @bautistaaa 😄: https://github.com/typehero/typehero/blob/0b7a25895c6ffc3707fd1a6348b31f2d38b81b95/tooling/scripts/dl-monaco.ts#L85-L86

${/* needs to import from monaco-editor to access the Environment type */ ''}
declare let MonacoEnvironment: import("monaco-editor").Environment | undefined;

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions