Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bug: array-type automatic fix changes type logic when used with conditional types #10519

Closed
@lunedis

Description

@lunedis

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.7.2&fileType=.tsx&code=C4TwDgpgBAKuEEYBCEBmB7ATtAvFAgppgIYgA8AzsJgJYB2A5gHwDcAUKJLPAvqsBExQ8VWowDaAXXYd43SACYUGbGRhNhBIqTVQIADwF0AJhSij6DKAH5z1S1ABcUOgFcAtgCNBrWVziKfAKYahp4MHqGECZmFow2dmJWzm5eglLsnNABEAoAovqQAMYCxqGaABQRBkamiQ62cckuHt6YAJQZQA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6AQ2mncNqNPRREXAPbRI4MAF8QUoA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

type Type1Before = Array<string>;
type Type1After = string[];

type Type2Before<T> = Array<T extends string ? string : number>;
type Type2After<T> = T extends string ? string : number[];
type Type2Expected<T> = (T extends string ? string : number)[];

ESLint Config

{
  "rules": {
    "@typescript-eslint/array-type": "error"
  }
}

tsconfig

{
  "compilerOptions": {
    // ...
  }
}

Expected Result

the automatic fix for

type Type2Before<T> = Array<T extends string ? string : number>;

should result in

type Type2Expected<T> = (T extends string ? string : number)[];

Actual Result

it results in

type Type2After<T> = T extends string ? string : number[];

which is a different type.

Additional Info

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions