Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bug: [prefer-nullish-coalescing] bad handling of computed members #10890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
OlivierZal opened this issue Feb 26, 2025 · 1 comment
Closed
4 tasks done

Bug: [prefer-nullish-coalescing] bad handling of computed members #10890

OlivierZal opened this issue Feb 26, 2025 · 1 comment
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@OlivierZal
Copy link
Contributor

OlivierZal commented Feb 26, 2025

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.7.2&fileType=.tsx&code=MYewdgzgLgBAhjAvDA5AIxQWAFA4CYCmwANnAE4EzEGwAeAXDAN7yPRkCWYA5gDQxo2UTjxgBfGAB8YYAK7FiOHLQD8AOgQBCZHIUwVMWgG04AXRiMUAMxAgsubAVoAHEGVgsxQA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Y6RAM0WlqYSNkAC1pkA9gEMkyMswDm6KL2jjokcGAC%2BILUA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

const a = 'b';

declare let x: { a: string, b: string } | null

x?.a != null ? x[a] : 'foo'

ESLint Config

module.exports = {
  parser: "@typescript-eslint/parser",
  rules: {
    "@typescript-eslint/prefer-nullish-coalescing": ["error"],
  },
};

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true
  }
}

Expected Result

x?.a != null ? x[a] : 'foo' should not report

Actual Result

x?.a != null ? x[a] : 'foo' reports

Additional Info

Raised in #10733 (comment)

Root cause: the rule doesn't handle well computed members.

A fix is ready in the perimeter of #10861: f69b588

PR branch playground

Cc @kirkwaiblinger

@OlivierZal OlivierZal added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Feb 26, 2025
@OlivierZal OlivierZal changed the title Bug: [prefer-nullish-coalescing] wrong handling of computed members Bug: [prefer-nullish-coalescing] bad handling of computed members Feb 26, 2025
@kirkwaiblinger kirkwaiblinger added accepting prs Go ahead, send a pull request that resolves this issue and removed bug Something isn't working labels Feb 27, 2025
@ronami ronami added bug Something isn't working and removed triage Waiting for team members to take a look labels Mar 2, 2025
@OlivierZal
Copy link
Contributor Author

@JoshuaKGoldberg, @kirkwaiblinger, this one can be closed given that #10861 has been merged.

@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Apr 1, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Development

No branches or pull requests

4 participants