feat(eslint-plugin): [prefer-nullish-coalescing] support `if` statement assignment (`??=`) and fix several minor bugs #10861

OlivierZal · 2025-02-21T09:18:56Z

PR Checklist

Addresses an existing open issue: fixes Enhancement: [prefer-nullish-coalescing] should support if statement assignment (??=) #10829, Bug: [prefer-nullish-coalescing] bad handling of computed members #10890, Bug: [prefer-nullish-coalescing] has various bugs around multi-part nullishness checks #10733
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

typescript-eslint · 2025-02-21T09:19:00Z

Thanks for the PR, @OlivierZal!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-02-21T09:19:17Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`513b085`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/67e02a4849254e0008c6f2ef
😎 Deploy Preview	https://deploy-preview-10861--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2025-02-21T09:19:49Z

View your CI Pipeline Execution ↗ for commit 513b085.

Command	Status	Duration	Result
`nx run-many --target=build --exclude website --...`	✅ Succeeded	1s	View ↗
`nx run-many --target=clean`	✅ Succeeded	11s	View ↗

☁️ Nx Cloud last updated this comment at 2025-03-24 13:01:58 UTC

codecov · 2025-02-21T09:46:29Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.00%. Comparing base (8474474) to head (513b085).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10861      +/-   ##
==========================================
+ Coverage   87.97%   88.00%   +0.03%     
==========================================
  Files         470      470              
  Lines       16709    16763      +54     
  Branches     4710     4735      +25     
==========================================
+ Hits        14699    14753      +54     
  Misses       1664     1664              
  Partials      346      346

Flag	Coverage Δ
unittest	`88.00% <100.00%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...eslint-plugin/src/rules/consistent-type-exports.ts	`88.78% <100.00%> (-0.21%)`	⬇️
...ckages/eslint-plugin/src/rules/no-unsafe-return.ts	`97.18% <100.00%> (-0.04%)`	⬇️
...lint-plugin/src/rules/prefer-nullish-coalescing.ts	`96.68% <100.00%> (+1.02%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

packages/website/src/components/lib/createCompilerOptions.ts

packages/eslint-plugin/src/rules/no-unsafe-return.ts

packages/eslint-plugin/src/rules/consistent-type-exports.ts

OlivierZal · 2025-02-25T22:47:06Z

Ready for review: new feature in the playground

While moving / refactoring the nodesInsideTestNode loop, and adding tests:

185667d fixes Bug: [prefer-nullish-coalescing] has various bugs around multi-part nullishness checks #10733
f69b588 fixes Bug: [prefer-nullish-coalescing] bad handling of computed members #10890.

In the playground:

❌ main branch playground

✅ PR branch playground

Cc @kirkwaiblinger

packages/eslint-plugin/tests/rules/prefer-nullish-coalescing.test.ts

kirkwaiblinger · 2025-03-22T18:24:48Z

packages/eslint-plugin/tests/rules/prefer-nullish-coalescing.test.ts

I think it looks good enough for me! IMO we're just going for a best effort on comment placement.

Thanks!

OlivierZal · 2025-03-23T15:43:34Z

@JoshuaKGoldberg, the latest commit doesn't seem related to PR's failure (which was ok one commit before).

Merging main didn’t help.

JoshuaKGoldberg · 2025-03-24T11:50:22Z

Yeah 😬 #10992 - we can ignore those failures.

JoshuaKGoldberg

I regret not thinking more on comments earlier, thanks Kirk for the catch. After playing around with a bunch more cases there are only a couple more comment locations I could break. Getting there! 🚀

packages/eslint-plugin/tests/rules/prefer-nullish-coalescing.test.ts

JoshuaKGoldberg

Super, thanks the thorough PR & discussion! 🔥

DarkDrek · 2025-03-26T14:34:21Z

Hi is there an option to disable this only for assignments and keep the general lint for the other types?

kirkwaiblinger · 2025-03-26T14:39:46Z

@DarkDrek see conversation at #10995

OlivierZal marked this pull request as draft February 21, 2025 09:19

OlivierZal force-pushed the prefer-nullish-coalescing-10829 branch 3 times, most recently from 25f4ea7 to 46330a5 Compare February 22, 2025 22:49

OlivierZal marked this pull request as ready for review February 22, 2025 22:51

OlivierZal force-pushed the prefer-nullish-coalescing-10829 branch from 505fd3e to 1299a38 Compare February 23, 2025 22:13

OlivierZal commented Feb 24, 2025

View reviewed changes

packages/website/src/components/lib/createCompilerOptions.ts Show resolved Hide resolved

OlivierZal commented Feb 24, 2025

View reviewed changes

packages/eslint-plugin/src/rules/no-unsafe-return.ts Show resolved Hide resolved

OlivierZal commented Feb 24, 2025

View reviewed changes

packages/eslint-plugin/src/rules/consistent-type-exports.ts Show resolved Hide resolved

OlivierZal commented Feb 24, 2025

View reviewed changes

packages/eslint-plugin/src/rules/consistent-type-exports.ts Show resolved Hide resolved

OlivierZal force-pushed the prefer-nullish-coalescing-10829 branch 2 times, most recently from 144036b to 1299a38 Compare February 24, 2025 18:21

support if statement assignment

fcc9bea

OlivierZal force-pushed the prefer-nullish-coalescing-10829 branch from 1299a38 to fcc9bea Compare February 24, 2025 18:24

improve logic

4e3a723

OlivierZal force-pushed the prefer-nullish-coalescing-10829 branch from 46cbf12 to 849bf03 Compare February 25, 2025 17:53

OlivierZal marked this pull request as draft February 25, 2025 17:56

OlivierZal force-pushed the prefer-nullish-coalescing-10829 branch from 4a72913 to 60091c8 Compare February 25, 2025 18:10

fix false positive

185667d

OlivierZal force-pushed the prefer-nullish-coalescing-10829 branch from 96c95a8 to 16150a2 Compare February 25, 2025 22:38

OlivierZal marked this pull request as ready for review February 25, 2025 22:40

OlivierZal mentioned this pull request Feb 26, 2025

Bug: [prefer-nullish-coalescing] bad handling of computed members #10890

Closed

4 tasks

handle computed expression (patch for existing issue)

f69b588

OlivierZal force-pushed the prefer-nullish-coalescing-10829 branch from 24210d9 to f69b588 Compare February 26, 2025 09:43

add tests

ed7be4c

after review

168a228

OlivierZal dismissed JoshuaKGoldberg’s stale review via 168a228 March 19, 2025 08:34

OlivierZal added 3 commits March 19, 2025 09:47

forgot the noFormat

4440b11

fix test

50bf59e

Handle comments

92ef701

OlivierZal requested review from JoshuaKGoldberg and kirkwaiblinger March 19, 2025 16:11

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Mar 19, 2025

OlivierZal and others added 5 commits March 19, 2025 17:18

fix naming and add test

727109a

improve indentation

7035591

fix type

fc806c5

simplify

8858559

remove duplicated test case

271db29

kirkwaiblinger approved these changes Mar 22, 2025

View reviewed changes

kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Mar 22, 2025

Merge branch 'main' into prefer-nullish-coalescing-10829

513b085

JoshuaKGoldberg requested changes Mar 24, 2025

View reviewed changes

packages/eslint-plugin/tests/rules/prefer-nullish-coalescing.test.ts Show resolved Hide resolved

JoshuaKGoldberg added awaiting response Issues waiting for a reply from the OP or another party and removed 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labels Mar 24, 2025

OlivierZal requested a review from JoshuaKGoldberg March 24, 2025 13:08

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Mar 24, 2025

JoshuaKGoldberg approved these changes Mar 24, 2025

View reviewed changes

JoshuaKGoldberg merged commit 7151489 into typescript-eslint:main Mar 24, 2025
58 of 60 checks passed

This was referenced Mar 24, 2025

Bug: [prefer-nullish-coalescing] has various bugs around multi-part nullishness checks #10733

Closed

Bug: [prefer-nullish-coalescing] "inside" comments are removed while fixing #10994

Closed

typescript-eslint locked and limited conversation to collaborators Mar 26, 2025

Uh oh!

feat(eslint-plugin): [prefer-nullish-coalescing] support if statement assignment (??=) and fix several minor bugs #10861

feat(eslint-plugin): [prefer-nullish-coalescing] support if statement assignment (??=) and fix several minor bugs #10861

Uh oh!

Conversation

OlivierZal commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Feb 21, 2025

Uh oh!

netlify bot commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud bot commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

OlivierZal commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

kirkwaiblinger Mar 22, 2025

Choose a reason for hiding this comment

Uh oh!

OlivierZal commented Mar 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoshuaKGoldberg commented Mar 24, 2025

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DarkDrek commented Mar 26, 2025

Uh oh!

kirkwaiblinger commented Mar 26, 2025

Uh oh!

Uh oh!

feat(eslint-plugin): [prefer-nullish-coalescing] support `if` statement assignment (`??=`) and fix several minor bugs #10861

feat(eslint-plugin): [prefer-nullish-coalescing] support `if` statement assignment (`??=`) and fix several minor bugs #10861

OlivierZal commented Feb 21, 2025 •

edited

Loading

netlify bot commented Feb 21, 2025 •

edited

Loading

nx-cloud bot commented Feb 21, 2025 •

edited

Loading

codecov bot commented Feb 21, 2025 •

edited

Loading

OlivierZal commented Feb 25, 2025 •

edited

Loading

OlivierZal commented Mar 23, 2025 •

edited

Loading