-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(eslint-plugin): [prefer-nullish-coalescing] support if
statement assignment (??=
) and fix several minor bugs
#10861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JoshuaKGoldberg
merged 22 commits into
typescript-eslint:main
from
OlivierZal:prefer-nullish-coalescing-10829
Mar 24, 2025
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
fcc9bea
support if statement assignment
OlivierZal 4e3a723
improve logic
OlivierZal 185667d
fix false positive
OlivierZal f69b588
handle computed expression (patch for existing issue)
OlivierZal ed7be4c
add tests
OlivierZal 2db7af7
simplify and add test
OlivierZal e9b280a
Merge branch 'main' into prefer-nullish-coalescing-10829
OlivierZal fc478dc
fix error
OlivierZal 5e59468
add "IfStatement without curly brackets" use case
OlivierZal 54e0f50
Merge branch 'main' into prefer-nullish-coalescing-10829
OlivierZal 8e1a6a6
add test
OlivierZal 1e10987
Merge branch 'main' into prefer-nullish-coalescing-10829
OlivierZal 168a228
after review
OlivierZal 4440b11
forgot the `noFormat`
OlivierZal 50bf59e
fix test
OlivierZal 92ef701
Handle comments
OlivierZal 727109a
fix naming and add test
OlivierZal 7035591
improve indentation
OlivierZal fc806c5
fix type
OlivierZal 8858559
simplify
OlivierZal 271db29
remove duplicated test case
kirkwaiblinger 513b085
Merge branch 'main' into prefer-nullish-coalescing-10829
OlivierZal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.