-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebugSomething isn't workingSomething isn't workingpackage: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugin
Description
Before You File a Bug Report Please Confirm You Have Done The Following...
- I have tried restarting my IDE and the issue persists.
- I have updated to the latest version of the packages.
- I have searched for related issues and found none that matched my issue.
- I have read the FAQ and my problem is not listed.
Playground Link
Repro Code
async function foo() {
(console.log('foo'), Promise.resolve('foo'));
}ESLint Config
module.exports = {
"rules": {
"@typescript-eslint/no-floating-promises": "warn"
}
}tsconfig
Expected Result
suggestion gives
async function foo() {
await (console.log('foo'), Promise.resolve('foo'));
}Actual Result
suggestion gives
async function foo() {
await ((console.log('foo'), Promise.resolve('foo')));
}Additional Info
Noticed in #11479 since prettier now formats comma operator expressions as (a, b); instead of a, b;
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebugSomething isn't workingSomething isn't workingpackage: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugin
{ "compilerOptions": { "strictNullChecks": true } }