-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebugSomething isn't workingSomething isn't workingpackage: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugin
Description
Before You File a Bug Report Please Confirm You Have Done The Following...
- I have tried restarting my IDE and the issue persists.
- I have updated to the latest version of the packages.
- I have searched for related issues and found none that matched my issue.
- I have read the FAQ and my problem is not listed.
Playground Link
Repro Code
interface MyError<T> { }
declare const error: MyError<number>;
error.toString();ESLint Config
{
"rules": {
"@typescript-eslint/no-base-to-string": [
"error",
{
"ignoredTypeNames": [
"MyError"
]
}
]
}
}tsconfig
Expected Result
There should be no lints.
Actual Result
'error' will use Object's default stringification format ('[object Object]') when stringified. 4:1 - 4:6
Additional Info
I know you could add MyError<number> to the ignoredTypeNames, but that would only take care of a single possible generic type.
At runtime the generics don't exist, so whether toString() is overridden or not, can't depend on the generics. I think the ignoredTypeNames should be based on the type without generics.
There is some discussion in #11420
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebugSomething isn't workingSomething isn't workingpackage: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugin
{ "compilerOptions": { "strictNullChecks": true } }