Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Getting the new parser into AST Explorer #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
platinumazure opened this issue Jan 22, 2019 · 9 comments
Closed

Getting the new parser into AST Explorer #125

platinumazure opened this issue Jan 22, 2019 · 9 comments
Labels
external This issue is with another package, not typescript-eslint itself

Comments

@platinumazure
Copy link
Contributor

AST Explorer has the latest typescript-eslint-parser (from the ESLint org) available for use, but we'll want to get the new parser out there.

Anyone know where to start?

Vaguely related question: Do we intend to set up a web demo somewhere?

(Might be off-topic as this is not strictly an issue in this repo-- apologies if that's the case)

@platinumazure platinumazure added the triage Waiting for team members to take a look label Jan 22, 2019
@ikatyang
Copy link
Contributor

FYI, fkling/astexplorer#377.

@j-f1 j-f1 added external This issue is with another package, not typescript-eslint itself and removed triage Waiting for team members to take a look labels Jan 22, 2019
@j-f1
Copy link
Contributor

j-f1 commented Jan 22, 2019

Web demo would be cool.

@bradzacher
Copy link
Member

Web demos for eslint are hard.

I started working on a universal eslint repl module a while ago (the idea being you'd self host it, pass it your plugin, and it would give you a UI that is AST explorer + rule checker in one that users can link to in issues).

However the problem is that a lot of eslint essentially requires access to the filesystem via fs (i.e. one use is to iterate through the list of rule source files - see requireindex in our plugin).

There are packages like eslint-web which are modified versions of eslint to work in the browser, but they lag behind and don't work as well as you might like.

For us to create a web demo, it would probably be a fair chunk of work.

@bradzacher
Copy link
Member

@armano2 has pointed out that eslint-plugin-vue has this setup for their repo, so we can look to leveraging(/stealing) their work to make interactive docs happen:

https://mysticatea.github.io/eslint-plugin-es/rules/no-json-superset.html
https://mysticatea.github.io/vue-eslint-editor/

Note that even with this codebase as a starting point - this is still a non-trivial amount of work due to the need for build tooling and such.

@mysticatea
Copy link
Member

I think it's not a steal :D

Also, https://mysticatea.github.io/vue-eslint-demo/ is an existing playground, which supports old typescript-eslint-parser. I think that it's not hard to fork that for this repository. I can work in this weekend.

@j-f1
Copy link
Contributor

j-f1 commented Jan 23, 2019

https://github.com/jvilk/BrowserFS

armanio123 pushed a commit to armanio123/typescript-eslint that referenced this issue Jan 24, 2019
@mysticatea
Copy link
Member

I'm sorry, I'm not sure if I can work in this weekend because of the flu. 🤒

@JamesHenry
Copy link
Member

Looks like the reason for the initial issue has been resolved, as AST explorer added @typescript-eslint/parser to its list

@JamesHenry
Copy link
Member

A separate interactive playground is definitely a nice to have too :)

@typescript-eslint typescript-eslint locked as resolved and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external This issue is with another package, not typescript-eslint itself
Projects
None yet
Development

No branches or pull requests

6 participants