Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[explicit-module-boundary-types] rule requires types on functions that are not directly returned #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bradzacher opened this issue May 30, 2020 · 0 comments · Fixed by #2135
Closed

[explicit-module-boundary-types] rule requires types on functions that are not directly returned #2134

bradzacher opened this issue May 30, 2020 · 0 comments · Fixed by #2135
Labels
bug Something isn't working has pr there is a PR raised to close this package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@bradzacher
Copy link
Member

Repro

{
  "rules": {
    "@typescript-eslint/<rule>": ["<setting>"]
  }
}
function foo(): unknown {
  return new Proxy(apiInstance, {
    get: (target, property) => {
	  // implementation
    },
  });
}

Expected Result

No errors

Actual Result

    get: (target, property) => {
          ^^^^^^  ^^^^^^^^ Arguments are reported as untyped
@bradzacher bradzacher added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin has pr there is a PR raised to close this labels May 30, 2020
bradzacher added a commit that referenced this issue May 30, 2020
@bradzacher
feat(eslint-plugin): [explicit-module-boundary-types] improve accuracy
a176991 
This is a large refactor of the code so that it only checks the functions that should be checked.
Fixes #2134

Also added an option `allowArgumentsExplicitlyTypedAsAny`  in case for some reason users want to allow explicit `any`s for argument types
Fixes #2119
@bradzacher bradzacher mentioned this issue May 30, 2020
Merged
@bradzacher bradzacher mentioned this issue May 30, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working has pr there is a PR raised to close this package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
1 participant
@bradzacher