Thanks to visit codestin.com
Credit goes to github.com

Skip to content

allowAutomaticSingleRunInference causes incorrect type information #6184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Dec 8, 2022 · 3 comments
Closed

allowAutomaticSingleRunInference causes incorrect type information #6184

JoshuaKGoldberg opened this issue Dec 8, 2022 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@JoshuaKGoldberg
Copy link
Member

Overview

Forking from #6176:

It's a bit funky with --fix from what I've noticed.
The fix re-runs won't have proper type information so rules like the no-unsafe-* rules will report false errors on fixed files that won't show up on a non-fixing run.

We need to figure out a better solution for the fix case before we can really roll this out to everyone I think, or else we'll create a really flaky and confusing experience.

@bradzacher - do you have a repro available? I can work on one if not.

I'd consider this a bug we should tackle. Perhaps we can use the same builder/watch programs that we do for IDEs?
@JoshuaKGoldberg JoshuaKGoldberg added bug Something isn't working triage Waiting for team members to take a look labels Dec 8, 2022
@bradzacher
Copy link
Member

I can't seem to repro it right now - but I do remember seeing it on our repo. I did a --fix run and I got a bunch of no-unsafe-* errors which ofc disappeared after a second run.

There's probably a complex combination of library types or something that is needed.
I tried creating an isolated repro here https://github.com/bradzacher/6184-repro

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 12, 2022
Closed
1 task
@bradzacher
Copy link
Member

There is one issue here: #3851
IDK if it's still an issue (needs re-investigation)

@JoshuaKGoldberg
Copy link
Member Author

#3851 still repros for me. Marking this issue as a duplicate of that one. "Great"!

@JoshuaKGoldberg JoshuaKGoldberg added duplicate This issue or pull request already exists and removed bug Something isn't working triage Waiting for team members to take a look labels Apr 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoshuaKGoldberg @bradzacher