Description
Before You File a Documentation Request Please Confirm You Have Done The Following...
- I have looked for existing open or closed documentation requests that match my proposal.
- I have read the FAQ and my problem is not listed.
Suggested Changes
https://typescript-eslint.io/contributing/pull-requests#addressing-feedback-and-beyond has this to say about PR reviews:
Once we have reviewed your PR, we will provide any feedback that needs addressing. If you feel a requested change is wrong, don't be afraid to discuss with us in the comments. Once the feedback is addressed, and the PR is reviewed, we'll ensure the branch is up to date with
main
, and merge it for you.
Note that this doesn't mention what PR authors should do after they've addressed our feedback. Do they explicitly re-request review (spoiler: yes, this is it) from the reviewer? Do they sit there and wait patiently the way @mahdi-farnia did in #5852 (sorry again!)?
Let's explicitly mention in the docs page that, yes, you should re-request our review to let us know it's ready.