Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Repo: Enable logical-assignment-operators internally? #7461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Aug 12, 2023 · 0 comments · Fixed by #7484
Closed

Repo: Enable logical-assignment-operators internally? #7461

JoshuaKGoldberg opened this issue Aug 12, 2023 · 0 comments · Fixed by #7484
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

TIL that https://eslint.org/docs/latest/rules/logical-assignment-operators exists but isn't enabled in any of our internal linting. That's a pity - I think it's a nice rule for cleaning up code. Shall we enable it?

'logical-assignment-operators': ["error", "always", { enforceForIfStatements: true }],
@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for team members to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs labels Aug 12, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 12, 2023
Merged
3 tasks
@bradzacher bradzacher added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Aug 15, 2023
@NotWoods NotWoods mentioned this issue Aug 16, 2023
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: enable logical-assignment-operators rule internally NotWoods/typescript-eslint
2 participants
@JoshuaKGoldberg @bradzacher