Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Repo: Playground code refactor: Playground.tsx state switches #7630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Sep 11, 2023 · 0 comments · Fixed by #8686
Closed

Repo: Playground code refactor: Playground.tsx state switches #7630

JoshuaKGoldberg opened this issue Sep 11, 2023 · 0 comments · Fixed by #8686
Labels
accepting prs Go ahead, send a pull request that resolves this issue locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs website: playground

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

From #6843 (comment), referring to all the logical ternaries in Playground.tsx:

i have a feeling that i should extract this to separate component, this and/or condition chain is getting complex

https://github.com/typescript-eslint/typescript-eslint/pull/6843/files#diff-c76545bc907e11e58eb71533f91f9887abb2a21dc4d8d2a389317dffbbf5a72c

There are indeed a lot of logical conditions in that file. It'd be nice to streamline the logic a bit to be more readable / straightforward / less complex. Maybe a dedicated component or two? Maybe an enum that gets switched on in render logic?
@JoshuaKGoldberg JoshuaKGoldberg added repo maintenance things to do with maintenance of the repo, and not with code/docs accepting prs Go ahead, send a pull request that resolves this issue website: playground labels Sep 11, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 11, 2023
Merged
3 tasks
@armano2 armano2 mentioned this issue Sep 28, 2023
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Nov 29, 2023
Merged
3 tasks
@abrahamguo abrahamguo mentioned this issue Mar 16, 2024
Merged
3 tasks
@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Jun 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs website: playground
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(website): simplify playground logic abrahamguo/typescript-eslint
1 participant
@JoshuaKGoldberg