Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Repo: Add unit tests inside type-utils #8358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshuaKGoldberg opened this issue Feb 3, 2024 · 2 comments
Closed

Repo: Add unit tests inside type-utils #8358

JoshuaKGoldberg opened this issue Feb 3, 2024 · 2 comments
Labels
accepting prs Go ahead, send a pull request that resolves this issue locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: type-utils Issues related to the @typescript-eslint/type-utils package repo maintenance things to do with maintenance of the repo, and not with code/docs tests anything to do with testing

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

packages/type-utils provides a suite of types/TypeScript-related functions. They're used in many rules. But because we don't merge coverage reports across packages (#6701), it shows up as having surprisingly low unit test coverage. E.g. builtinSymbolLikes.ts on 1d7447f right now has 0%. https://app.codecov.io/gh/typescript-eslint/typescript-eslint/blob/1d7447f4fd5e2fbae4211eb5fc07e93cf570b6b3/packages%2Ftype-utils%2Fsrc%2FbuiltinSymbolLikes.ts

@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for team members to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs tests anything to do with testing package: type-utils Issues related to the @typescript-eslint/type-utils package labels Feb 3, 2024
@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Feb 24, 2024
@JoshuaKGoldberg
Copy link
Member Author

Status update: coverage is at ~62.44% now per https://app.codecov.io/gh/typescript-eslint/typescript-eslint/commit/5d9f49c62735e05fde53e1d4ac651218938769b7/tree/packages/type-utils. Nice! Shoutout @y-hsgw for sending a bunch of PRs. πŸŽ‰

@JoshuaKGoldberg
Copy link
Member Author

I think we can consider this closed for now. We're getting to the point of remaining functions not being super valuable. Thanks for the PRs, everyone!

If there are individual functions anybody thinks should be tested, I'd suggest filing an individual repo tooling issue with why.

@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Oct 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepting prs Go ahead, send a pull request that resolves this issue locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. package: type-utils Issues related to the @typescript-eslint/type-utils package repo maintenance things to do with maintenance of the repo, and not with code/docs tests anything to do with testing
Projects
None yet
Development

No branches or pull requests

1 participant