-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Bug: Type incompatibility with fixupPluginRules()
from @eslint/compat
#9115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Wow they committed the cardinal sin of using Honestly I think that this is a bug in their types, not ours. You'll find that their types also don't work with They've ultimately defined these super loose janky types that nobody can align with. We already define super loose types for this assignment to be permissive and accept many things - but they're even looser than we are which is insane to consider. typescript-eslint/packages/utils/src/ts-eslint/Rule.ts Lines 667 to 688 in 510153b
So yeah I'd file an issue upstream and get them to define something that'll work with the existing ecosystem. ((separately they should consider using our |
Good point, thanks! I also was able to confirm that the I reported it over here: |
I'll close this out then as there's nothing for us to action from our side. |
Uh oh!
There was an error while loading. Please reload this page.
Before You File a Bug Report Please Confirm You Have Done The Following...
Relevant Package
utils
Playground Link
No response
Repro Code
ESLint Config
tsconfig
Expected Result
The types for
SharedConfig.RuleEntry
match the return type forfixupPluginRules()
from@eslint/compat
Actual Result
The types do not match:
Additional Info
No response
Versions
@typescript-eslint/eslint-plugin
7.9.1-alpha.6
@typescript-eslint/parser
7.9.1-alpha.6
@typescript-eslint/rule-tester
7.9.1-alpha.6
@typescript-eslint/scope-manager
7.9.1-alpha.6
@typescript-eslint/typescript-estree
7.9.1-alpha.6
@typescript-eslint/type-utils
7.9.1-alpha.6
@typescript-eslint/utils
7.9.1-alpha.6
TypeScript
5.4.5
ESLint
9.3.0
node
20.13.1
I also tried the latest v8 alpha (
@typescript-eslint/[email protected]
), which should be compatible with ESLint v9, but this also results in the same error.The text was updated successfully, but these errors were encountered: