Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(eslint-plugin): [class-literal-property-style] don't report nodes with override keyword #10135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2024
+31 −1
Merged

fix(eslint-plugin): [class-literal-property-style] don't report nodes with override keyword #10135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/eslint-plugin/src/rules/class-literal-property-style.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ export default createRule<Options, MessageIds>({
MethodDefinition(node): void {
if (
node.kind !== 'get' ||
node.override ||
!node.value.body ||
node.value.body.body.length === 0
) {
Expand Down Expand Up @@ -222,7 +223,7 @@ export default createRule<Options, MessageIds>({
}
},
PropertyDefinition(node): void {
if (!node.readonly || node.declare) {
if (!node.readonly || node.declare || node.override) {
return;
}
const { properties } =
Expand Down
29 changes: 29 additions & 0 deletions packages/eslint-plugin/tests/rules/class-literal-property-style.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,35 @@ class Mx {
`,
options: ['getters'],
},
{
// https://github.com/typescript-eslint/typescript-eslint/issues/3602
// getter with override modifier should be ignored
code: `
declare abstract class BaseClass {
get cursor(): string;
}
class ChildClass extends BaseClass {
override get cursor() {
return 'overridden value';
}
}
`,
},
{
// https://github.com/typescript-eslint/typescript-eslint/issues/3602
// property with override modifier should be ignored
code: `
declare abstract class BaseClass {
protected readonly foo: string;
}
class ChildClass extends BaseClass {
protected override readonly foo = 'bar';
}
`,
options: ['getters'],
},
],
invalid: [
{
Expand Down
Loading