Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(rule-tester): allow custom filename outside directory #10147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix(rule-tester): allow custom filename outside directory #10147

merged 1 commit into from
Oct 21, 2024

Conversation

lotmek
Copy link
Contributor

@lotmek lotmek commented Oct 14, 2024 •
edited
Loading

PR Checklist

Overview

Allowing custom filenames outside the current directory in RuleTester.
Fix is similar to the one in ESLint fix: handle absoulte file paths in RuleTester #17989.
Since we cannot directly use FlatConfigArray, I mock it with an Object containing a basePath property.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @lotmek!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Oct 14, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 35aaeb7
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/670d95cd2d41ba0008cc122e
😎 Deploy Preview https://deploy-preview-10147--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 94 (🟢 up 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Oct 14, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 35aaeb7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Oct 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.17%. Comparing base (f153eb1) to head (35aaeb7).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
packages/rule-tester/src/RuleTester.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10147      +/-   ##
==========================================
- Coverage   86.18%   86.17%   -0.01%     
==========================================
  Files         428      428              
  Lines       14981    14983       +2     
  Branches     4344     4345       +1     
==========================================
+ Hits        12911    12912       +1     
  Misses       1724     1724              
- Partials      346      347       +1
Flag Coverage Δ
unittest 86.17% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/rule-tester/src/RuleTester.ts 63.31% <66.66%> (-0.07%) ⬇️

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice workaround! ✨

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 15, 2024
kirkwaiblinger
kirkwaiblinger approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hugely appreciate this! ♥️

@JoshuaKGoldberg JoshuaKGoldberg merged commit 70a381d into typescript-eslint:main Oct 21, 2024
73 of 74 checks passed
@AviVahl
Copy link

AviVahl commented Oct 21, 2024

I believe we see a regression with this patch downstream:

TypeError: Cannot read properties of undefined (reading 'parse')
      at ParserService.parseSync (/home/avi/projects/stylable/node_modules/eslint/lib/services/parser-service.js:36:33)
      at #flatVerifyWithoutProcessors (/home/avi/projects/stylable/node_modules/eslint/lib/linter/linter.js:1680:47)
      at Linter._verifyWithFlatConfigArrayAndWithoutProcessors (/home/avi/projects/stylable/node_modules/eslint/lib/linter/linter.js:1992:49)
      at Linter._verifyWithFlatConfigArray (/home/avi/projects/stylable/node_modules/eslint/lib/linter/linter.js:2081:21)
      at Linter.verify (/home/avi/projects/stylable/node_modules/eslint/lib/linter/linter.js:1528:61)
      at Linter.RuleTester.#linter.linter.verify (/home/avi/projects/stylable/node_modules/@typescript-eslint/rule-tester/src/RuleTester.ts:202:18)
      at RuleTester.runRuleForItem (/home/avi/projects/stylable/node_modules/@typescript-eslint/rule-tester/src/RuleTester.ts:770:33)
      at RuleTester.#testValidTemplate (/home/avi/projects/stylable/node_modules/@typescript-eslint/rule-tester/src/RuleTester.ts:863:25)
      at Context.<anonymous> (/home/avi/projects/stylable/node_modules/@typescript-eslint/rule-tester/src/RuleTester.ts:541:40)

@JoshuaKGoldberg
Copy link
Member

@AviVahl prove it. 😉

https://typescript-eslint.io/contributing/issues#commenting

@jeremybanka jeremybanka mentioned this pull request Oct 21, 2024
Closed
4 tasks
@RobinTail
Copy link
Contributor

@JoshuaKGoldberg , proof: #10191 (comment)

@typescript-eslint typescript-eslint locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug(rule-tester): Error while testing file with filename that is not a subdirectory of test file
5 participants
@lotmek @AviVahl @JoshuaKGoldberg @RobinTail @kirkwaiblinger