Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

y-hsgw
Copy link
Contributor

@y-hsgw y-hsgw commented Oct 17, 2024

PR Checklist

Overview

Added the Flat Config/Legacy Config tabs to the configuration examples on the rule pages.

📕

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @y-hsgw!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 7c7a061
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6718c95770d43300085f36f9
😎 Deploy Preview https://deploy-preview-10164--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Oct 17, 2024

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few small things. Thanks!

extendsBaseRuleName,
page.file.stem,
true,
)})`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a ; to be consistent with the legacy configs & rest of the site:

Suggested change
)})`,
)});`,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it in c2aad1c.

"rules": ${rules}
}`;

const eslitnConfig = `{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const eslitnConfig = `{
const eslintConfig = `{

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it in c2aad1c.

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Oct 22, 2024
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Oct 23, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 yay, thanks!

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 23, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit a744765 into typescript-eslint:main Oct 23, 2024
65 checks passed
@y-hsgw y-hsgw deleted the feature/rule-pages-to-use-flat-config branch October 23, 2024 23:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: update configuration examples on individual rule pages to use flat config
2 participants