chore: update eslint version internally to latest #10244
Conversation
|
Thanks for the PR, @kirkwaiblinger! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 436ff1d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10244 +/- ##
=======================================
Coverage 86.50% 86.51%
=======================================
Files 430 430
Lines 15088 15123 +35
Branches 4380 4400 +20
=======================================
+ Hits 13052 13083 +31
- Misses 1679 1683 +4
Partials 357 357
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -137,7 +137,6 @@ | |||
| "@types/estree": "link:./tools/dummypkg", | |||
| "@types/node": "^20.0.0", | |||
| "@types/react": "^18.2.14", | |||
| "eslint": "^9", | |||
There was a problem hiding this comment.
Unsure of exactly what we wanna do with the various places the dependency is declared. I removed the resolutions field and did yarn up eslint. But, lmk if we want to manage it differently
There was a problem hiding this comment.
These changes are due to eslint/eslint#18799
packages/eslint-plugin/tests/rules/no-useless-constructor.test.ts
Outdated
Show resolved
Hide resolved
packages/eslint-plugin/tests/rules/no-useless-constructor.test.ts
Outdated
Show resolved
Hide resolved
packages/eslint-plugin/tests/rules/no-useless-constructor.test.ts
Outdated
Show resolved
Hide resolved
packages/eslint-plugin/tests/rules/no-useless-constructor.test.ts
Outdated
Show resolved
Hide resolved
packages/eslint-plugin/tests/rules/no-useless-constructor.test.ts
Outdated
Show resolved
Hide resolved
packages/eslint-plugin/tests/rules/no-useless-constructor.test.ts
Outdated
Show resolved
Hide resolved
packages/eslint-plugin/tests/rules/no-useless-constructor.test.ts
Outdated
Show resolved
Hide resolved
packages/eslint-plugin/tests/rules/no-useless-constructor.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Brad Zacher <[email protected]>
PR Checklist
Overview
yarn up eslint